T-shirts for hackers, designed by a hacker! @ ControlAlt.shop [CLICK HERE]   
Page MenuHomePhabricator

[config] Disable limited width on the main page and associated history page
Closed, ResolvedPublic1 Estimated Story Points

Description

Background

  • We would like to disable limited width on main pages

User story

  • As a reader, I want the main page to be in full width, so that I am able to more easily scan the main pages of articles

Requirements

  • Main pages should appear in full width on Vector 2022 skin
  • Viewing the history of the main page should appear in full width on Vector 2022 skin. (T309489)

BDD

Feature: Full Width Display on Wikipedia's Main Page in Vector 2022 Skin

  Scenario: Main page unaffected by limited width setting on Vector 2022 skin
    Given the user has selected the "Enable limited width" option in Special:Preferences/Appearance
    And the user is viewing the Wikipedia main page using the Vector 2022 skin with side bar menus collapsed
    Then the main page should still be displayed in full width

  Scenario: History of the main page unaffected by limited width setting on Vector 2022 skin
    Given the user has selected the "Enable limited width" option in Special:Preferences/Appearance
    And the user is viewing the history of the Wikipedia main page using the Vector 2022 skin with side bar menus collapsed
    Then the history page should still be displayed in full width

Test Steps

Test Case 1: Verify Main Page Unaffected by Limited Width Setting on Vector 2022 Skin

  1. Log in to Wikipedia and navigate to Special:Preferences/Appearance.
  2. Ensure the "Enable limited width" option is selected.
  3. Navigate to the Wikipedia main page using the Vector 2022 skin and collapse (hide) any side bar menus.
  4. AC1: Confirm that the main page is displayed in full width despite the "Enable limited width" setting being active.

Test Case 2: Verify History of Main Page Unaffected by Limited Width Setting on Vector 2022 Skin

  1. Log in to Wikipedia and navigate to Special:Preferences/Appearance.
  2. Ensure the "Enable limited width" option is selected.
  3. Navigate to the history page of the Wikipedia main page using the Vector 2022 skin and collapse (hide) any side bar menus.
  4. AC2: Confirm that the history page is displayed in full width despite the "Enable limited width" setting being active.

Design

  • n/a

Acceptance criteria

  • Apply requirements
  • Ensure that we test alongside the new notice
  • Ensure communication criteria is complete - i.e. check with @ovasileva or @sgrabarczuk before making this change

Communication criteria - does this need an announcement or discussion?

  • Communication across wikis required

Old ticket version: (keeping just in case, the notice is now tracked in a separate ticket
I'll propose the following solution for this ticket:

  • The main page will appear as a wide-only page like Revision History. It will always have full-width. This will improve CPL measurements for readability at all font sizes.
  • In the Appearance menu, the width radio buttons will remain active whether or not the user is on a wide-only page (they will no longer be hidden)
  • Any changes to the width setting on a wide-only page will take effect as normal on other pages that are not wide-only. The setting remains configurable on these pages.
  • On wide-only pages a line will appear beneath the width control radio buttons that reads: "This page is always wide"
  • This text will only appear in the menu on wide-only pages.
  • The message box will show where the setting doesn't apply
  • The message will be hidden when the setting does apply

@JScherer-WMF walks through the rationale for this in this video.

Screenshot 2024-02-01 at 2.38.22 PM.png (1×752 px, 83 KB)

POC here: https://gerrit.wikimedia.org/r/1003104

Sign off steps

If it passed QA, also resolve T309489

QA Results - Beta

ACStatusDetails
1T357706#9797474
2T357706#9797474

QA Results - PROD

ACStatusDetails
1T357706#9828083
2T357706#9828083

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
ovasileva renamed this task from Disable limited width on the home page and show alert to Disable limited width on the home page .Apr 2 2024, 4:26 PM
ovasileva updated the task description. (Show Details)
ovasileva added a subscriber: sgrabarczuk.
Jdlrobson renamed this task from Disable limited width on the home page to Disable limited width on the home page and associated history page.Apr 5 2024, 3:17 AM
Jdlrobson updated the task description. (Show Details)
Jdlrobson updated the task description. (Show Details)
Jdlrobson changed the status of subtask T309489: Main Page history is not full width from Open to Stalled.
Jdlrobson renamed this task from Disable limited width on the home page and associated history page to [config] Disable limited width on the home page and associated history page.Apr 5 2024, 6:24 AM
Jdlrobson set the point value for this task to 1.

Change #1020886 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Enable limited width on all main pages

https://gerrit.wikimedia.org/r/1020886

Blocked on Olga giving the green light to push ahead with deployment.

Jdlrobson lowered the priority of this task from High to Medium.Apr 30 2024, 10:52 PM
ovasileva raised the priority of this task from Medium to High.May 1 2024, 8:58 AM

Change #1020886 abandoned by Jdlrobson:

[operations/mediawiki-config@master] Enable limited width on all main pages

Reason:

Not working on this but feel free to restore when we are.

https://gerrit.wikimedia.org/r/1020886

sgrabarczuk renamed this task from [config] Disable limited width on the home page and associated history page to [config] Disable limited width on the main page and associated history page.Thu, May 9, 1:20 PM
sgrabarczuk updated the task description. (Show Details)

Change #1030200 had a related patch set uploaded (by Kimberly Sarabia; author: Kimberly Sarabia):

[operations/mediawiki-config@master] Deploy disabled limited width on main page

https://gerrit.wikimedia.org/r/1030200

Change #1030289 had a related patch set uploaded (by Kimberly Sarabia; author: Kimberly Sarabia):

[mediawiki/skins/Vector@master] Deploy limited width settings

https://gerrit.wikimedia.org/r/1030289

Change #1030289 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Deploy limited width settings

https://gerrit.wikimedia.org/r/1030289

Change #1030200 abandoned by Kimberly Sarabia:

[operations/mediawiki-config@master] Deploy disabled limited width on main page

Reason:

Since we want this to be the default for all wikis, we should change it in the Vector config instead. See 1030289





https://gerrit.wikimedia.org/r/1030200

Change #1030200 restored by Kimberly Sarabia:

[operations/mediawiki-config@master] Deploy disabled limited width on main page

https://gerrit.wikimedia.org/r/1030200

Change #1030200 merged by jenkins-bot:

[operations/mediawiki-config@master] Deploy disabled limited width on main page

https://gerrit.wikimedia.org/r/1030200

Mentioned in SAL (#wikimedia-operations) [2024-05-14T13:40:38Z] <logmsgbot> lucaswerkmeister-wmde@deploy1002 Started scap: Backport for [[gerrit:1030200|Deploy disabled limited width on main page (T357706)]], [[gerrit:1031047|Phase 5: Vector-2022.js should no longer load legacy Vector code (T301212)]]

Mentioned in SAL (#wikimedia-operations) [2024-05-14T13:43:17Z] <logmsgbot> lucaswerkmeister-wmde@deploy1002 jdlrobson and ksarabia and lucaswerkmeister-wmde: Backport for [[gerrit:1030200|Deploy disabled limited width on main page (T357706)]], [[gerrit:1031047|Phase 5: Vector-2022.js should no longer load legacy Vector code (T301212)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-05-14T13:57:10Z] <logmsgbot> lucaswerkmeister-wmde@deploy1002 Finished scap: Backport for [[gerrit:1030200|Deploy disabled limited width on main page (T357706)]], [[gerrit:1031047|Phase 5: Vector-2022.js should no longer load legacy Vector code (T301212)]] (duration: 16m 32s)

Edtadros subscribed.

Test Result - Beta

Status: ❌ Fail
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

Test Steps

Test Case 1: Verify Main Page Unaffected by Limited Width Setting on Vector 2022 Skin

  1. Log in to Wikipedia and navigate to Special:Preferences/Appearance.
  2. Ensure the "Enable limited width" option is selected.
  3. Navigate to the Wikipedia main page using the Vector 2022 skin.

❌ 4. AC1: Confirm that the main page is displayed in full width despite the "Enable limited width" setting being active.

screenshot 60.mov.gif (1×2 px, 1 MB)

Test Case 2: Verify History of Main Page Unaffected by Limited Width Setting on Vector 2022 Skin

  1. Log in to Wikipedia and navigate to Special:Preferences/Appearance.
  2. Ensure the "Enable limited width" option is selected.
  3. Navigate to the history page of the Wikipedia main page using the Vector 2022 skin.

❌ 4. AC2: Confirm that the history page is displayed in full width despite the "Enable limited width" setting being active.

screenshot 61.mov.gif (1×2 px, 1 MB)

Talked about this in sync and this is best tested by collapsing menus.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

Test Steps

Test Case 1: Verify Main Page Unaffected by Limited Width Setting on Vector 2022 Skin

  1. Log in to Wikipedia and navigate to Special:Preferences/Appearance.
  2. Ensure the "Enable limited width" option is selected.
  3. Navigate to the Wikipedia main page using the Vector 2022 skin and collapse (hide) any side bar menus.
  4. AC1: Confirm that the main page is displayed in full width despite the "Enable limited width" setting being active.

screenshot 62.mov.gif (1×2 px, 1 MB)

Test Case 2: Verify History of Main Page Unaffected by Limited Width Setting on Vector 2022 Skin

  1. Log in to Wikipedia and navigate to Special:Preferences/Appearance.
  2. Ensure the "Enable limited width" option is selected.
  3. Navigate to the history page of the Wikipedia main page using the Vector 2022 skin and collapse (hide) any side bar menus.
  4. AC2: Confirm that the history page is displayed in full width despite the "Enable limited width" setting being active.

screenshot 340.png (1×2 px, 409 KB)

ovasileva claimed this task.

Test Result - PROD

Status: ✅ PASS
Environment: PROD
OS: macOS Sonoma 14.5
Browser: Chrome 125
Device: MBA
Emulated Device:NA

Test Artifact(s):

Test Steps

Test Case 1: Verify Main Page Unaffected by Limited Width Setting on Vector 2022 Skin

  1. Log in to Wikipedia and navigate to Special:Preferences/Appearance.
  2. Ensure the "Enable limited width" option is selected.
  3. Navigate to the Wikipedia main page using the Vector 2022 skin and collapse (hide) any side bar menus.
  4. AC1: Confirm that the main page is displayed in full width despite the "Enable limited width" setting being active.

2024-05-23_16-04-56 (1).gif (1×2 px, 3 MB)

Test Case 2: Verify History of Main Page Unaffected by Limited Width Setting on Vector 2022 Skin

  1. Log in to Wikipedia and navigate to Special:Preferences/Appearance.
  2. Ensure the "Enable limited width" option is selected.
  3. Navigate to the history page of the Wikipedia main page using the Vector 2022 skin and collapse (hide) any side bar menus.
  4. AC2: Confirm that the history page is displayed in full width despite the "Enable limited width" setting being active.

2024-05-23_16-07-04.png (768×2 px, 355 KB)